[Doc] Add 'static and Send constraints explanations to thread::spawn
#41980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamazeps
changed the title
'static and Send constraints explanations to thread::spawn'static and Send constraints explanations to thread::spawn
nagisa
reviewed
May 14, 2017
src/libstd/thread/mod.rs
Outdated
| /// - The `'static` constraint means that the closure and its return value | ||
| /// must have a lifetime of the whole program execution. The reason for this | ||
| /// is that threads can `detach` and outlive the lifetime they have been | ||
| /// created in. |
There was a problem hiding this comment.
Thread being able to outlive the scope it has been created in (i.e. detaching) is only an explanation for why closure itself is 'static, and not its return value. The return value has the 'static bound because the return value outlives the thread it is returned from; this is true regardless of whether the thread gets detached or not.
There was a problem hiding this comment.
They are actually linked.
The value a thread returns must outlive the closure, but the fact that the thread can detach implies that the closure must be 'static, since the value must live at least as long as the closure it must then also be 'static
|
r? @rust-lang/docs |
|
Tidy errors: |
|
Damn, that is valid markdown though... |
Mark-Simulacrum
added
the
S-waiting-on-review
frewsxcv
added
the
A-docs
|
@steveklabnik This looks read for review. |
|
@bors: r+ rollup thanks! |
|
📌 Commit 770bd57 has been approved by |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 24, 2017
[Doc] Add `'static` and `Send` constraints explanations to `thread::spawn` Part of rust-lang#29378. Explains why the constraints on the closure and its return value are `'static` and `Send`. Allows to tick of `thread::spawn` from the list of things to document in the `thread` module. r? @steveklabnik
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 24, 2017
[Doc] Add `'static` and `Send` constraints explanations to `thread::spawn` Part of rust-lang#29378. Explains why the constraints on the closure and its return value are `'static` and `Send`. Allows to tick of `thread::spawn` from the list of things to document in the `thread` module. r? @steveklabnik
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 24, 2017
[Doc] Add `'static` and `Send` constraints explanations to `thread::spawn` Part of rust-lang#29378. Explains why the constraints on the closure and its return value are `'static` and `Send`. Allows to tick of `thread::spawn` from the list of things to document in the `thread` module. r? @steveklabnik
bors
added a commit
that referenced
this pull request
May 24, 2017
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 25, 2017
[Doc] Add `'static` and `Send` constraints explanations to `thread::spawn` Part of rust-lang#29378. Explains why the constraints on the closure and its return value are `'static` and `Send`. Allows to tick of `thread::spawn` from the list of things to document in the `thread` module. r? @steveklabnik
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 25, 2017
[Doc] Add `'static` and `Send` constraints explanations to `thread::spawn` Part of rust-lang#29378. Explains why the constraints on the closure and its return value are `'static` and `Send`. Allows to tick of `thread::spawn` from the list of things to document in the `thread` module. r? @steveklabnik
bors
added a commit
that referenced
this pull request
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #29378.
Explains why the constraints on the closure and its return value are
'staticandSend.Allows to tick of
thread::spawnfrom the list of things to document in thethreadmodule.r? @steveklabnik